Fix check access on page load #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joonatank
force-pushed
the
fix-check-access-on-page-load
branch
3 times, most recently
from
5d3b36d
to
835eab4
Compare
joonatank
changed the base branch from
fix-middleware-running-on-asset-requests
to
chore-update-gql-types
joonatank
force-pushed
the
fix-check-access-on-page-load
branch
2 times, most recently
from
7a88fb9
to
e754155
Compare
In customer app user should have access to reservations and applications only if they own them (even if they have higher access in admin application). For unauthorized access return 404 error.
joonatank
force-pushed
the
fix-check-access-on-page-load
branch
from
e754155
to
6bfb1a8
Compare
vincit-matu
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ Changelog
customerapplication (url access) even if the user has access to the data./reservationspath will always be protected with same rules.🧪 Test plan
customerapp users withadmin(or other roles with access) are blocked seeing other users reservations and applications (similar to regular users) and receive 404 error. This works for all paths related to reservations and applications (i.e. user specific data).🎫 Tickets